On Tue, 23 Nov 2021 22:36:18 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> +++ b/src/event-parse.h
> @@ -125,6 +125,7 @@ enum tep_format_flags {
> TEP_FIELD_IS_LONG = 32,
> TEP_FIELD_IS_FLAG = 64,
> TEP_FIELD_IS_SYMBOLIC = 128,
> + TEP_FIELD_IS_RELATIVE = 256,
> };
>
> struct tep_format_field {
> @@ -153,12 +154,12 @@ struct tep_print_arg_atom {
>
> struct tep_print_arg_string {
> char *string;
> - int offset;
> + struct tep_format_field *field;
> };
>
> struct tep_print_arg_bitmask {
> char *bitmask;
> - int offset;
> + struct tep_format_field *field;
> };
>
We need to be careful about modifying content in event-parse.h. Because
this is exposed outside he library.
Although, I don't think this should be an issue.
We probably need to move some content out of that file if it isn't used in
any of the exposed APIs :-/
And since both libtracefs and trace-cmd do not reference any of the
tep_print_arg* fields, we probably should remove them before somebody does.
-- Steve
|