On Tue, Aug 17, 2021 at 6:40 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > [...] > > + > > +__hidden struct tracecmd_option * > > +out_add_buffer_option_v7(struct tracecmd_output *handle, const char *name, > > + unsigned short id, unsigned long long data_offset, > > + int cpus, struct data_file_write *cpu_data) > > > Why is this hidden, and not static? > > I noticed that you are using "out_" as a normal prefix. Is that really > needed? I use "out_" and "in_" prefixes for internal library functions, related to tracecmd_output and tracecmd_input handlers. For example, there are: int out_uncompress_block(struct tracecmd_output *handle); int in_uncompress_block(struct tracecmd_input *handle); > > [...] -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|