On Thu, Aug 19, 2021 at 10:34 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > OK, so I quickly went through the rest of the series, and this really > should have been at least 4 different patch sets. This series was > really hard to review, because it bounced around between clean ups, > sections, compressions, and conversions. > > Thus, I'm going to set this entire series to "Changes Requested". > > Please break this into at least 4 patch sets (here's 6 I would recommend). > > Patch set 1: Clean ups. > > Any change that was to make v6 work better with v7, or fix to v6 or > whatever. Should be first. It should be non-controversial, and we can > get that in right away. > > > Patch set 2: Sections: > > This adds the notion of v7, but also adds all the work that has to do > with sections. Anything that has to do with compression, should be the > "non-compressed" case. The focus of this series would be to simply > break up the file for v7 where it is grouped by sections. > > Patch set 3: Compression > > This is where you can add all the changes that deal with compression. > > > Patch set 4: Conversion > > This will add all the changes that are used to convert between v6 <-> v7. > > Patch set 5: Dump > > The changes here would be for dumping the output. > > Patch set 6: Documentation. > > And finally, add all the documentation at the end. > > This will make it much easier to understand, and manage. Let's not have > a 87 patch series again. It's just too big to manage. > > -- Steve Thanks for reviewing this huge patch set, Steven! I'll break it into 6 patch sets, as you proposed. -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|