On Thu, Apr 29, 2021 at 4:19 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Thu, 22 Apr 2021 10:17:13 +0300 > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > > > Adding a compression of the trace.dat file will change its structure. > > These changes are not backward compatible, the old trace-cmd binaries > > will not be able to read compressed trace files. Bumping the version to > > 7 will prevent old trace-cmd to read such files. > > But this series doesn't add anything to the file that breaks the > version. The version should be updated with the patch that breaks the > backward compatibility. of the file, not before. > I need the new version before the compression changes, because there is logic which relies on the new version. There is a check whether to read / write compression data based on the new file version. I was wondering if to put all changes into a single patchset, version + compression. Decided to split in two, although there is no sense to bump the version without adding a compression. > -- Steve [...] -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|