On Thu, 22 Apr 2021 10:17:13 +0300 "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > Adding a compression of the trace.dat file will change its structure. > These changes are not backward compatible, the old trace-cmd binaries > will not be able to read compressed trace files. Bumping the version to > 7 will prevent old trace-cmd to read such files. But this series doesn't add anything to the file that breaks the version. The version should be updated with the patch that breaks the backward compatibility. of the file, not before. -- Steve > > Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx> > --- > lib/trace-cmd/include/trace-cmd-local.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/trace-cmd/include/trace-cmd-local.h b/lib/trace-cmd/include/trace-cmd-local.h > index e8533b22..5578f00d 100644 > --- a/lib/trace-cmd/include/trace-cmd-local.h > +++ b/lib/trace-cmd/include/trace-cmd-local.h > @@ -14,7 +14,7 @@ void tracecmd_warning(const char *fmt, ...); > void tracecmd_fatal(const char *fmt, ...); > > /* trace.dat file format version */ > -#define FILE_VERSION 6 > +#define FILE_VERSION 7 > > #define _STR(x) #x > #define STR(x) _STR(x)
|