On Wed, Apr 7, 2021 at 7:55 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Wed, 7 Apr 2021 12:54:32 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > 3. A weak function specific to each library is a more straightforward > > > way and the user has the flexibility to control warnings per library. > > > The overhead to add library specific wrappers to those weak functions > > > is not so big. > > > > It's an unnecessary burden. You may add libtracecmd, and want to capture > > all the warnings and overwrite tracecmd_warning(), but then see that > > there's other warnings coming from libtraceevent and libtracefs that you > > never included (because libtracecmd pulled them in). And it's not obvious > > how to deal with them. > > I'm fine if you want to make them all weak, but I really like to have a > single function that can control all of them. I'll submit the next version with weak functions for each library and all of them using the __weak tep_vwarning() for the printing. > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|