On Wed, 7 Apr 2021 19:46:43 +0300 Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote: > I understood that idea from your comments, but have a few concerns: > > 1. That way we create a dependency, not logical to the user of the libraries. What dependency? > 2. That print functionality is not something logically specific to the > libtraceevent, it is not related to the main purpose of this library. Not sure what you mean by that? > 3. A weak function specific to each library is a more straightforward > way and the user has the flexibility to control warnings per library. > The overhead to add library specific wrappers to those weak functions > is not so big. It's an unnecessary burden. You may add libtracecmd, and want to capture all the warnings and overwrite tracecmd_warning(), but then see that there's other warnings coming from libtraceevent and libtracefs that you never included (because libtracecmd pulled them in). And it's not obvious how to deal with them. -- Steve
|