Hi Michal, On 11.03.21 г. 19:57, Michal Sojka wrote:
Hi Yordan, On Thu, Mar 11 2021, Yordan Karadzhov (VMware) wrote:In your case the installation fails to install the policy file used by Polkit. Note that this doesn't mean that the kernelshark installation itself fails.Yes, I know, but when something fails, users are confused ;-)
You are right here. We have to think how to make this message look more like a warning.
As far as I know the policy file can only go to a special locations so that Polkit can find it. Otherwise it will have no effect (I may be wrong on this).You're right. I looked at polkit sources and it really seems that only one location is supported. It is determined at configuration time so on some systems it may be different from /usr/share/... I'm talking specifically about NixOS, but it already has the patch I sent. So I leave it up to you whether to apply the patch or not. I think that supporting seamless installation into $HOME is useful if one wants to quickly use a newer version not available in their distribution.
Building, installing as root and testing the latest version shouldn't cause any problems/conflicts on your system. Note that there is a script in kernel-shark/build called "cmake_uninstall.sh". It is guaranteed that this script removes every single file that has been installed.
And BTW from the patch I see that you still use the old version that comes together with trace-cmd. If you are keen to try the latest version, checkout this one:
https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/This is a brand new version that has a lot of changes under the hood and needs user testing. We will be extremely happy to receive bug reports ;) or patches for this new version.
Thanks! Yordan
|