On Wed, Jan 22, 2020 at 12:28 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Wed, 22 Jan 2020 12:21:54 -0500 > Marcelo Diop-Gonzalez <marcgonzalez@xxxxxxxxxx> wrote: > > > > > Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez@xxxxxxxxxx> > > > > --- > > > > Makefile | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Makefile b/Makefile > > > > index efd9ed4..0b15bf5 100644 > > > > --- a/Makefile > > > > +++ b/Makefile > > > > @@ -348,7 +348,8 @@ TAGS: force > > > > > > > > cscope: force > > > > $(RM) cscope* > > > > - $(call find_tag_files) | cscope -b -q > > > > + $(call find_tag_files) > cscope.files > > > > + cscope -b -q > > > > > > I think the following should work too, without the need to create an > > > extra file: > > > > > > diff --git a/Makefile b/Makefile > > > index efd9ed4b..782df41b 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -348,7 +348,7 @@ TAGS: force > > > > > > cscope: force > > > $(RM) cscope* > > > - $(call find_tag_files) | cscope -b -q > > > + $(call find_tag_files) | cscope -b -q -i- > > > > Hi Steven! > > > > I think one problem with this is that it requires that you pass cscope a > > list of files to look in when using it after building the index. > > Running "cscope" > > with no arguments gives the output: "cscope: no source files found", whereas > > if cscope.files is populated, running "cscope" lets you look at everything that > > went into building the index. For example, I think running "make cscope" inside > > a kernel repository will spit out a 'cscope.files' (done in docscope() > > in ./scripts/tags.sh). > > But I guess it depends on how people usually like to use cscope (I'm > > no expert!). > > What do you think is best? > > As I do my development with emacs, I honestly have no opinion on the > use of cscope. ;-) > > Is it common practice to look at the file used for cscope? If it is, I find it useful to have cscope.files present just so that 'cscope' by itself works. Also I've been using https://github.com/dkogan/xcscope.el with emacs a bit, and it's easier to use with cscope.files present. I'm not too sure how common it is though, my only data point is myself I guess :) > then I'm OK with your approach, but we need to make sure we update > the .gitignore and clean make target to remove it. Ah good point! I'll send out another version if this way's the way to go. Thanks, -Marcelo > > Thanks! > > -- Steve
|