On Wed, 4 Sep 2019 10:48:37 +0000 "Uhanov, Kirill" <kirill.uhanov@xxxxxxxxx> wrote: Hmm, Patchwork doesn't want to pick this up. Probably because of the strange mime format that your mail client is using. I'll send this patch for you (using a From line for you). But if you want to contribute to Linux related projects, it may be a good idea to work with other intel developers to fix your mail client such that patches work as inlined. Thanks! -- Steve > tools lib trace-cmd: Fix typo with file descriptor conditions > > Signed-off-by: Kirill Uhanov <kirill.uhanov@xxxxxxxxx> > > > > diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c > > index 0bd0657..650b259 100644 > > --- a/lib/trace-cmd/trace-recorder.c > > +++ b/lib/trace-cmd/trace-recorder.c > > @@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags, > > goto out; > > fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644); > > - if (fd < 0) > > + if (fd2 < 0) > > goto err; > > recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb); > > > > -------------------------------------------------------------------- > Joint Stock Company Intel A/O > Registered legal address: Krylatsky Hills Business Park, > 17 Krylatskaya Str., Bldg 4, Moscow 121614, > Russian Federation > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies.
![]() |