libtracecmd is a library, containing functions that can be used without the trace-cmd application. However, some of the functions declared as libtracecmd APIs in trace-cmd.h depend on trace-cmd context. That causes a problem when other application uses the library. The problem can be observed when running kerneshark and there is a python module, loaded by the python plugin - there is a bunch of warnings. To resolve the problem, implementations of all trace-cmd independent functions are moved into libtracecmd. All libtracecmd functions, that depend on trace-cmd context are removed from the library and from trace-cmd.h file. [ v3 changes: - Removed accepted patches from the series. - Added new patch: "Update descriptions of "debug" libtracecmd APIs". - Renamed "plog*" library APIs to "tracecmd_plog*". - Rmoved "tracecmd" prefix from local variables. - Renamed trace_set_log_file to tracecmd_set_logfile. - Changed tracecmd_set_quiet() and tracecmd_get_quiet() APIs to work per tracecmd_output handler. v2 changes: - Added a new patch: Move trace-cmd-local.h from the application to the library. - Remove trace-output.c dependency of version.h. Moved FILE_VERSION_STRING define from top Makefile to trace-cmd-local.h. ] Tzvetomir Stoyanov (VMware) (4): trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd trace-cmd: Move plog() function to libtracecmd. trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd trace-cmd: Update descriptions of "debug" libtracecmd APIs include/trace-cmd/trace-cmd.h | 9 +- include/trace-cmd/trace-msg.h | 3 - lib/trace-cmd/include/trace-cmd-local.h | 2 - lib/trace-cmd/trace-msg.c | 8 +- lib/trace-cmd/trace-output.c | 28 ++++- lib/trace-cmd/trace-util.c | 139 ++++++++++++++++++++++-- tracecmd/include/trace-local.h | 2 - tracecmd/trace-cmd.c | 2 - tracecmd/trace-listen.c | 89 +++------------ tracecmd/trace-record.c | 17 ++- tracecmd/trace-stack.c | 56 +--------- 11 files changed, 199 insertions(+), 156 deletions(-) -- 2.21.0
![]() |