Hi Steven, On Wed, Aug 28, 2019 at 11:21 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > ... > > +/** > > + * tracecmd_stack_tracer_status - Check stack trace status > > + * @status: Returned stack trace status: > > + * 0 - not configured, disabled > > + * non 0 - enabled > > + * > > + * Returns -1 in case of an error, 0 if file does not exist > > + * (stack tracer not enabled) or 1 on successful completion. > > "(stack tracer not configured in kernel)" > > Saying "enabled" is ambiguous. > > > + */ > > +int tracecmd_stack_tracer_status(int *status) > > If we are making this a library function, shouldn't it be declared in > the trace-cmd.h file? > It is already part of trace-cmd.h, that was one of the problems - it was defined as library API, but implemented in the trace-cmd application. This patch moves the implementation in the library, the declaration in trace-cmd.h remains the same. > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|