libtracecmd is a library, containing functions that can be
used without the trace-cmd application. However, some of the
functions declared as libtracecmd APIs in trace-cmd.h
depend on trace-cmd context. That causes a problem when
other application uses the library. The problem can be
observed when running kerneshark and there is a python
module, loaded by the python plugin - there is a bunch
of warnings.
To resolve the problem, implementations of all trace-cmd
independent functions are moved into libtracecmd. All
libtracecmd functions, that depend on trace-cmd context
are removed from the library and from trace-cmd.h file.
[
v2 changes:
- Added a new patch:
Move trace-cmd-local.h from the application to the library.
- Remove trace-output.c dependency of version.h. Moved FILE_VERSION_STRING
define from top Makefile to trace-cmd-local.h.
]
Tzvetomir Stoyanov (VMware) (8):
trace-cmd: Move trace-cmd-local.h from the application to the library
trace-cmd: Move trace-output.c into the library code
trace-cmd: Move trace-msg.c into the library.
trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd
trace-cmd: Move trace-cmd global variable "debug" to libtracecmd
trace-cmd: Move plog() function to libtracecmd.
trace-cmd: Move trace-cmd APIs from trace-cmd.h to trace-local.h
trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd
Makefile | 3 -
include/trace-cmd/trace-cmd.h | 19 +-
.../include => include/trace-cmd}/trace-msg.h | 3 -
include/version.h | 5 -
lib/trace-cmd/Makefile | 2 +
.../trace-cmd}/include/trace-cmd-local.h | 7 +-
{tracecmd => lib/trace-cmd}/trace-msg.c | 4 +-
{tracecmd => lib/trace-cmd}/trace-output.c | 5 +-
lib/trace-cmd/trace-util.c | 162 ++++++++++++++++++
tracecmd/Makefile | 2 -
tracecmd/include/trace-local.h | 14 +-
tracecmd/trace-cmd.c | 3 -
tracecmd/trace-list.c | 2 +-
tracecmd/trace-listen.c | 77 ++-------
tracecmd/trace-read.c | 8 +-
tracecmd/trace-record.c | 8 +-
tracecmd/trace-stack.c | 56 +-----
17 files changed, 218 insertions(+), 162 deletions(-)
rename {tracecmd/include => include/trace-cmd}/trace-msg.h (79%)
rename {tracecmd => lib/trace-cmd}/include/trace-cmd-local.h (83%)
rename {tracecmd => lib/trace-cmd}/trace-msg.c (99%)
rename {tracecmd => lib/trace-cmd}/trace-output.c (99%)
--
2.21.0
|