Hi, > Thanks for the review (unfortunately, due to the rush to get > KernelShark 1.0 out, I already applied them, I should have Cc'd you on > them too). > > Should we make any of the above changes you mentioned to any of these > patches? I'm looking at releasing trace-cmd 2.8.4 with all these > changes and will hold off if you think it would be better to update > them. I don't think it matters. The PyLong thing was just really cosmetic, could've saved some lines of code. The bytes vs. unicode - well, python assumes that you give it a utf-8 string, so even if we start using non-ASCII identifiers (which I think is highly unlikely!), we'll likely use utf-8 in the kernel, and it would either way not be an issue. johannes
|