On Fri, 26 Jul 2019 09:31:57 +0200 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2019-07-19 at 18:46 -0400, Steven Rostedt wrote: > > > +#if PY_MAJOR_VERSION >= 3 > [...] > > +#define PY_INT_AS_LONG PyLong_AsLong > > #else > [...] > > +#define PY_INT_AS_LONG PyInt_AS_LONG > > +#endif > > I probably would've gone for only having a single > > #define PyLong_AsLong PyInt_AS_LONG > > in the python2 case, but doesn't really matter. > > > Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Hi Johannes, Thanks for the review (unfortunately, due to the rush to get KernelShark 1.0 out, I already applied them, I should have Cc'd you on them too). Should we make any of the above changes you mentioned to any of these patches? I'm looking at releasing trace-cmd 2.8.4 with all these changes and will hold off if you think it would be better to update them. Thanks! -- Steve
|