On Thu, 27 Jun 2019 18:40:27 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > Hi Greg, > > Thanks for the fix! > > I agree that we have to remove the unused hashing functions, but may I > ask you to do a little bit of extra work here. > I think that if we are going to keep only one hashing function this > function can be called simply knuth_has (not knuth_has8). Hi Yordan, Small nit. I think you meant "knuth_hash" not "knuth_has", even though I'm sure knuth has a lot ;-) > > Also the comment on top which refers to the TAOCP book must be modified > stating that the original idea from the book (32 bit hash) was adapted > in order to be used for small tables. Ack. -- Steve
|