On Tue, 25 Jun 2019 23:01:01 -0700
Greg Thelen <gthelen@xxxxxxxxxx> wrote:
> Neither knuth_hash16() nor knuth_hash() are used.
> Delete them.
>
Yordan,
Do you foresee that we will be using the other two versions of the hash?
-- Steve
> Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>
> ---
> lib/trace-cmd/trace-filter-hash.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/lib/trace-cmd/trace-filter-hash.c b/lib/trace-cmd/trace-filter-hash.c
> index 39b28790e0bc..c56628f69ff0 100644
> --- a/lib/trace-cmd/trace-filter-hash.c
> +++ b/lib/trace-cmd/trace-filter-hash.c
> @@ -29,26 +29,6 @@ static inline uint8_t knuth_hash8(uint32_t val)
> return UINT8_C(val) * UINT8_C(157);
> }
>
> -static inline uint16_t knuth_hash16(uint32_t val)
> -{
> - /*
> - * Multiplicative hashing function.
> - * Multiplication by the Prime number, closest to the golden
> - * ratio of 2^16.
> - */
> - return UINT16_C(val) * UINT16_C(40507);
> -}
> -
> -static inline uint32_t knuth_hash(uint32_t val)
> -{
> - /*
> - * Multiplicative hashing function.
> - * Multiplication by the Prime number, closest to the golden
> - * ratio of 2^32.
> - */
> - return val * UINT32_C(2654435761);
> -}
> -
> struct tracecmd_filter_id_item *
> tracecmd_filter_id_find(struct tracecmd_filter_id *hash, int id)
> {
|