Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Date: Tue, 16 Apr 2019 14:49:39 +0200
- Cc: Kees Cook <keescook@xxxxxxxxxxxx>, Olof Johansson <olof@xxxxxxxxx>, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>, Joel Fernandes <joelaf@xxxxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Qais Yousef <qais.yousef@xxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, Manoj Rao <linux@xxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, atish patra <atishp04@xxxxxxxxx>, Daniel Colascione <dancol@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Guenter Roeck <groeck@xxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Karim Yaghmour <karim.yaghmour@xxxxxxxxxxx>, Android Kernel Team <kernel-team@xxxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>
- In-reply-to: <20190416083306.5646a687@gandalf.local.home>
- References: <CAOesGMheoZda84OSz9spQ7p66wot5S_9aaqaKC=QYp+8utASXA@mail.gmail.com> <20190408203601.GF133872@google.com> <CAOesGMibHCuMPCYkc8V++Z2Kuf3YQf_OjYn18GvDgzTy6ubV=g@mail.gmail.com> <CAJWu+or0hWce9+7aEfTHoOR8cptRbzHYVL-bPdJWGZH20dbo7Q@mail.gmail.com> <CAOesGMiuGK-Sbqo2z=1ab070JONav1LF82MRRLCdX-4+14_XZA@mail.gmail.com> <20190411031540.ehezr6kq7ouobpzx@ast-mbp.dhcp.thefacebook.com> <CAOesGMgiPB=7FE7tXXHes7WSLfByyPxirOStoH21NZqMwaUihQ@mail.gmail.com> <20190415104109.64d914f3@gandalf.local.home> <CAGXu5j+KPVRcOJ3Ue9ZQF93GyaDhvCnFCvJ_C3WKCx2=SNdDyg@mail.gmail.com> <20190416083306.5646a687@gandalf.local.home>
- User-agent: Mutt/1.11.4 (2019-03-13)
On Tue, Apr 16, 2019 at 08:33:06AM -0400, Steven Rostedt wrote:
> On Mon, 15 Apr 2019 22:50:10 -0500
> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> > On Mon, Apr 15, 2019 at 9:41 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > > I agree with this assessment. We shouldn't use config.gz as precedence
> > > for this solution. config.gz should have been in debugfs to begin with,
> > > but I don't believe debugfs was around when config.gz was introduced.
> > > (Don't have time to look into the history of the two).
> >
> > I don't agree with this: /proc/config.gz is used by a lot of tools
> > that do sanity-check of running systems. This isn't _debugging_...
> > it's verifying correct kernel builds. It's a fancy version of checking
> > /proc/version.
> >
>
> Then we should perhaps make a new file system call tarballs ;-)
>
> /sys/kernel/tarballs/
>
> and place everything there. That way it removes it from /proc (which is
> the worse place for that) and also makes it something other than debug.
> That's what I did for tracefs.
As horrible as that suggestion is, it does kind of make sense :)
We can't put this in debugfs as that's only for debugging and systems
should never have that mounted for normal operations (users want to
build ebpf programs), and /proc really should be for processes but that
horse is long left the barn.
But, I'm willing to consider putting this either in a system-fs-like
filesystem, or just in sysfs itself, we do have /sys/kernel/ to play
around in if the main objection is that we should not be cluttering up
/proc with stuff like this.
thanks,
greg k-h
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]