On Thu, 21 Feb 2019 16:38:29 +0000 Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote: > > Acked-by: Slavomir Kaslev <kaslevs@xxxxxxxxxx> Thanks for reviewing Slavomir! > > > > Side note: ksmodel_shift_backward/ksmodel_shift_forward look pretty similar. Can > > they be generalized to an either-directional ksmodel_shift taking the shift > > parameter as signed? If ksmodel_shift_backward/ksmodel_shift_forward need to be > > kept for backward compatibility, they can call ksmodel_shift (with a flipped > > sign in the backward case). > > > Thanks for the comment! > You are right. I think this can be done, but in a separate patch. I agree on both accounts. -- Steve
|