On Tue, 5 Feb 2019 10:14:49 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Mon, 4 Feb 2019 09:08:53 +0200 > Slavomir Kaslev <kaslevs@xxxxxxxxxx> wrote: > > I accepted your patches up to here with some slight modifications to > the subjects and change logs. Note, when referencing function names, > its mostly desirable to add a "()" to the end of them to make it stand > out that they are functions. Like tracecmd_msg_send_close(). > > But, this patch needs a change log to explain why this function should > return an error code. Is something going to rely on it in the future? > I think I'll take this patch anyway (and add a change log to it). Since it can fail, it would be good to return the error. -- Steve
|