On Thu, 7 Feb 2019 12:52:03 +0000 Slavomir Kaslev <kaslevs@xxxxxxxxxx> wrote: > On Tue, Feb 5, 2019 at 5:14 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > On Mon, 4 Feb 2019 09:08:53 +0200 > > Slavomir Kaslev <kaslevs@xxxxxxxxxx> wrote: > > > > I accepted your patches up to here with some slight modifications to > > the subjects and change logs. Note, when referencing function names, > > its mostly desirable to add a "()" to the end of them to make it stand > > out that they are functions. Like tracecmd_msg_send_close(). > > > > But, this patch needs a change log to explain why this function should > > return an error code. Is something going to rely on it in the future? > > Apologies for the empty commit message on this one, somehow it slipped > me before sending. > > The intention for this patch was simply stylistic, as with close() > which returns error code but it's seldom checked. > > Feel free to drop it if you find that unnecessary. Patch 7 and 8 don't > depend on it. Should I resend them? > I'll drop this patch and apply the other two (after looking a bit more at them). No need to resend. Thanks, -- Steve
|