Re: [tip: x86/urgent] x86/sgx: Set active memcg prior to shmem allocation
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip: x86/urgent] x86/sgx: Set active memcg prior to shmem allocation
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Mon, 18 Jul 2022 22:44:05 +0200
- Cc: Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <b1476c7d-c514-227f-2735-092b5afb7d3a@intel.com>
- References: <20220520174248.4918-1-kristen@linux.intel.com> <165419442842.4207.2566961916839377924.tip-bot2@tip-bot2> <YtUs3MKLzFg+rqEV@zn.tnic> <b1476c7d-c514-227f-2735-092b5afb7d3a@intel.com>
On Mon, Jul 18, 2022 at 11:52:54AM -0700, Dave Hansen wrote:
> As a further cleanup, it would probably be nice to explicitly document
> that "lookup" and "alloc" also require a subsequent "put".
Certainly. That is not really clear from the sparse comments over it.
> It would also be nice to change sgx_encl_get_backing() to
> __sgx_encl_get_backing() to make it clear that it's an internal thing.
>
> So, I think the _code_ is OK as-is, but it could use some more love.
That makes a lot more sense.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]