Re: [tip: perf/core] perf tests: Disable bp_signal testing for arm64
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip: perf/core] perf tests: Disable bp_signal testing for arm64
- From: Leo Yan <leo.yan@xxxxxxxxxx>
- Date: Tue, 22 Oct 2019 21:43:08 +0800
- Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Brajeswar Ghosh <brajeswar.linux@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Michael Petlan <mpetlan@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Song Liu <songliubraving@xxxxxx>, Souptick Joarder <jrdr.linux@xxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>
- In-reply-to: <20191022131423.GA17920@willie-the-truck>
- References: <20191018085531.6348-3-leo.yan@linaro.org> <157169993406.29376.12473771029179755767.tip-bot2@tip-bot2> <20191022131423.GA17920@willie-the-truck>
- User-agent: Mutt/1.9.4 (2018-02-28)
On Tue, Oct 22, 2019 at 02:14:25PM +0100, Will Deacon wrote:
[...]
> > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> > index c1c2c13..166f411 100644
> > --- a/tools/perf/tests/bp_signal.c
> > +++ b/tools/perf/tests/bp_signal.c
> > @@ -49,14 +49,6 @@ asm (
> > "__test_function:\n"
> > "incq (%rdi)\n"
> > "ret\n");
> > -#elif defined (__aarch64__)
> > -extern void __test_function(volatile long *ptr);
> > -asm (
> > - ".globl __test_function\n"
> > - "__test_function:\n"
> > - "str x30, [x0]\n"
> > - "ret\n");
> > -
> > #else
> > static void __test_function(volatile long *ptr)
> > {
> > @@ -302,10 +294,15 @@ bool test__bp_signal_is_supported(void)
> > * stepping into the SIGIO handler and getting stuck on the
> > * breakpointed instruction.
> > *
> > + * Since arm64 has the same issue with arm for the single-step
> > + * handling, this case also gets suck on the breakpointed
> > + * instruction.
>
> Freudian slip?
:D sorry for typo: s/suck/stuck.
Thanks for review and will send a patch to fix it.
Thanks,
Leo Yan
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]