Re: [PATCH] x86/crypto: Add missing RETs
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] x86/crypto: Add missing RETs
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Date: Fri, 6 Jul 2018 16:57:35 +0200
- Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, Mike Galbraith <efault@xxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, luto@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, brgerst@xxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dvlasenk@xxxxxxxxxx, h.peter.anvin@xxxxxxxxx, linux-tip-commits <linux-tip-commits@xxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
- In-reply-to: <20180706140643.u2vau63nncg23hmi@treble>
- References: <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com> <20180624104449.GA20159@avx2> <20180625072438.GA19063@gmail.com> <20180625131932.sge43esxdb5ejoxg@treble> <20180626064930.GB25879@gmail.com> <20180626123154.unjji5glpokedwal@treble> <20180705075815.GA20903@gmail.com> <20180706140643.u2vau63nncg23hmi@treble>
- User-agent: Mutt/1.9.4 (2018-02-28)
* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > Great, I'd be perfectly fine with such an approach.
> >
> > Also, if we have that then we could re-apply Alexey's patch and switch to INT3
> > (only on 64-bit kernels) without any trouble, because objtool should detect any
> > execution flow bugs before the INT3 could trigger, right?
> >
> > I.e. any INT3 fault would show a combination of *both* an objtool bug and a
> > probable code flow bug - which I suspect would warrant crashing the box ...
>
> Sounds good to me. I can take Alexey's patch and submit a 64-bit
> version of it, along with the relevant objtool changes (though it may
> still be a few weeks before I get the chance).
Sounds good to me, thanks!
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]