Re: [PATCH] x86/crypto: Add missing RETs
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] x86/crypto: Add missing RETs
- From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
- Date: Sun, 24 Jun 2018 13:44:49 +0300
- Cc: Borislav Petkov <bp@xxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, Mike Galbraith <efault@xxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, jpoimboe@xxxxxxxxxx, luto@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, brgerst@xxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dvlasenk@xxxxxxxxxx, h.peter.anvin@xxxxxxxxx, linux-tip-commits <linux-tip-commits@xxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20180624071105.GA29407@gmail.com>
- References: <20180507213755.GA32406@avx2> <tip-51bad67ffbce0aaa44579f84ef5d05597054ec6a@git.kernel.org> <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com>
- User-agent: Mutt/1.9.4 (2018-02-28)
On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote:
> > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
> > otherwise they run into INT3 padding due to
> >
> > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")
> >
> > leading to spurious debug exceptions.
> >
> > Mike Galbraith <efault@xxxxxx> took care of all the remaining callsites.
>
> Note that 51bad67ffbce has been zapped because it caused too many problems like
> this, but the explicit RETs make sense nevertheless.
So commit which found real bug(s) was zapped.
OK
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]