Re: [tip:x86/boot] x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/boot] x86/boot/compressed/64: Handle 5-level paging boot if kernel is above 4G
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Date: Tue, 13 Feb 2018 10:43:56 +0100
- Cc: Andrei Vagin <avagin@xxxxxxxxxxxxx>, tip-bot for Jacob Shin <tipbot@xxxxxxxxx>, kirill.shutemov@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, willy@xxxxxxxxxxxxx, gorcunov@xxxxxxxxxx, bp@xxxxxxx, peterz@xxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, luto@xxxxxxxxxxxxxx
- In-reply-to: <20180213090249.vnjwitt657jabnlt@node.shutemov.name>
- References: <tip-b4b56015ed1c98cbc9469e35ebbc4373a2844030@git.kernel.org> <20180213065155.GA14087@outlook.office365.com> <20180213080816.vwh64jiz23frjiot@node.shutemov.name> <20180213084121.GA19906@outlook.office365.com> <20180213090249.vnjwitt657jabnlt@node.shutemov.name>
- User-agent: NeoMutt/20170609 (1.8.3)
* Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote:
> On Tue, Feb 13, 2018 at 12:41:22AM -0800, Andrei Vagin wrote:
> > On Tue, Feb 13, 2018 at 11:08:16AM +0300, Kirill A. Shutemov wrote:
> > > On Mon, Feb 12, 2018 at 10:51:56PM -0800, Andrei Vagin wrote:
> > > > Hi Kirill,
> > > >
> > > > Something is wrong in this patch.
>
> Could you please check if this makes a difference?
>
> diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
> index 70b30f2bc9e0..99a0e7993252 100644
> --- a/arch/x86/boot/compressed/head_64.S
> +++ b/arch/x86/boot/compressed/head_64.S
> @@ -332,7 +332,7 @@ ENTRY(startup_64)
>
> /* Make sure we have GDT with 32-bit code segment */
> leaq gdt(%rip), %rax
> - movl %eax, gdt64+2(%rip)
> + movq %rax, gdt64+2(%rip)
> lgdt gdt64(%rip)
There's another suspicious looking pattern as well:
leaq startup_32(%rip), %rax
movl %eax, BP_code32_start(%rsi)
...
movl BP_code32_start(%esi), %eax
leaq startup_64(%rax), %rax
...
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]