Re: [tip:x86/pti] x86/cpu/AMD: Use LFENCE_RDTSC instead of MFENCE_RDTSC
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/pti] x86/cpu/AMD: Use LFENCE_RDTSC instead of MFENCE_RDTSC
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Mon, 8 Jan 2018 18:01:36 +0100
- Cc: Tom Lendacky <thomas.lendacky@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, bp@xxxxxxxxx, dwmw@xxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxxx, pjt@xxxxxxxxxx, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, tim.c.chen@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, dave.hansen@xxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20180108164803.GF2462@work-vm>
- References: <20180105160756.23786.4220.stgit@tlendack-t1.amdoffice.net> <tip-0bf17c102177d5da9363bf8b1e4704b9996d5079@git.kernel.org> <alpine.DEB.2.20.1801081105120.1735@nanos> <1b179b8b-6cc8-d736-81dc-2445be4baf02@citrix.com> <alpine.DEB.2.20.1801081208500.1735@nanos> <4d9a1f0d-a401-3f0f-9ee2-dd42f4b4716a@amd.com> <929a34a1-e3bc-b1c8-4c71-196610c0d02a@citrix.com> <20180108164803.GF2462@work-vm>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
On 08/01/2018 17:48, Dr. David Alan Gilbert wrote:
>> If your hypervisor is lying to you about the primary family, then all
>> bets are off. I don't expect there will be any production systems doing
>> this.
> It's not that an unusual thing to do on qemu/kvm - to specify the lowest
> common denominator of the set of CPUs in your data centre (for any one
> vendor); it does tend to get some weird combinations.
Agreed. But on a hypervisor we pretty much know that:
- the MSR_AMD64_DE_CFG doesn't exist unless you have a fix
- setting the MSR_AMD64_DE_CFG bit to 1 if you have a fix can be done
independent of the family
So all KVM needs is a X86_FEATURE_LFENCE_SERIALIZE, it doesn't matter if
it's because of the family or because Linux has set MSR_F10H_DE_CFG.
The guest will either try setting the MSR bit and #GP, or it will find
it already set and do nothing.
Of course no code for this has been written yet.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]