Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Wed, 8 Nov 2017 18:14:12 +0100
- Cc: Peter Anvin <hpa@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, ricardo.neri-calderon@xxxxxxxxxxxxxxx, Chris Metcalf <cmetcalf@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Andrew Lutomirski <luto@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, ray.huang@xxxxxxx, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Chen Yucong <slaoub@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "linux-tip-commits@xxxxxxxxxxxxxxx" <linux-tip-commits@xxxxxxxxxxxxxxx>
- In-reply-to: <68c11f7a-cd26-0fdc-0ac5-939a72c22227@redhat.com>
- References: <1509935277-22138-8-git-send-email-ricardo.neri-calderon@linux.intel.com> <tip-1e5db223696afa55e6a038fac638f759e1fdcc01@git.kernel.org> <ca980b88-a668-29cc-3f5a-506088473282@redhat.com> <CA+55aFyzb5D6DfM_1mxcMbuYOaxZWFxqfv7WZS6zdkqnN7+p0A@mail.gmail.com> <3cdde8ac-500c-ddad-5ea5-a733e2c98d84@redhat.com> <CA+55aFzwOSbbGpV7dkmkOJ3ScP2pXqkkbPMjzU9qAmVyzSzoAw@mail.gmail.com> <68c11f7a-cd26-0fdc-0ac5-939a72c22227@redhat.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
On 08/11/2017 18:09, Denys Vlasenko wrote:
> On 11/08/2017 05:57 PM, Linus Torvalds wrote:
>> On Wed, Nov 8, 2017 at 8:53 AM, Denys Vlasenko <dvlasenk@xxxxxxxxxx>
>> wrote:
>>> We can postpone enabling UMIP by default by a year or so.
>>> By this time, new Wine will be on majority of users' machines.
>>
>> So you are suggesting we run unnecessarily insecure, only in order to
>> not do the emulation that we already have the code for and that the
>> patch implements?
>
> We ran insecure in this way for ~25 years.
>
>> Why?
>
> To avoid having to maintain more obscure, rarely executed code.
As a start, you could propose a patch to disable the emulation code
through a sysctl or Kconfig symbol. I would be surprised if it takes
more time than what you've spent writing emails in this thread.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]