Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct
- From: Borislav Petkov <bp@xxxxxxx>
- Date: Thu, 10 Nov 2016 18:57:18 +0100
- Cc: mingo@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet>
- References: <20161103125556.15482-2-bp@alien8.de> <tip-1ce9cd7f9f0b71af7c496b816734bc2dc699363a@git.kernel.org> <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet>
- User-agent: NeoMutt/20161014 (1.7.1)
On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote:
> Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the
> original code and fixes the behavior.
>
> > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)),
> > + ((high & MCI_IPID_MCATYPE) >> 16));
Argh, the macro should be adding the additional parentheses:
#define HWID_MCATYPE(hwid, mcatype) (((hwid) << 16) | (mcatype))
That should fix the issue too.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
