Re: [tip:x86/cpu] x86/cpu: Strip any /proc/ cpuinfo model name field whitespace
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/cpu] x86/cpu: Strip any /proc/ cpuinfo model name field whitespace
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Thu, 28 May 2015 20:33:21 +0200
- Cc: Prarit Bhargava <prarit@xxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, luto@xxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, dvlasenk@xxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, imammedo@xxxxxxxxxx, brgerst@xxxxxxxxx, mingo@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, fenghua.yu@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, bp@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <2A88ADE0-90EF-4A94-BF4D-463E478B2FDA@zytor.com>
- User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, May 28, 2015 at 09:57:15AM -0700, H. Peter Anvin wrote:
> Why?!
>
> We are taking about 48 bytes run once per cpu. It isn't worth it to
> optimize, in fact the extra code size hurts more.
I wanted to save us the redundant copying of the exact same bytes.
Because when there's no preceding whitespace, p and q point at the same
thing so we end up doing *p = *p.
OTOH, without the optimization, the code is even simpler.
I can remove it if you wanna - I don't care all that much.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]