Commit-ID: 87cdb98affe54b6f390f4622b254569b90820817 Gitweb: http://git.kernel.org/tip/87cdb98affe54b6f390f4622b254569b90820817 Author: Ingo Molnar <mingo@xxxxxxxxxx> AuthorDate: Fri, 3 Apr 2015 11:06:43 +0200 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitDate: Tue, 19 May 2015 15:47:10 +0200 x86/fpu: Add debugging check to fpu__save() Document the function a bit more and add debugging check that we are only running this with the current task. Reviewed-by: Borislav Petkov <bp@xxxxxxxxx> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> Cc: H. Peter Anvin <hpa@xxxxxxxxx> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Cc: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> --- arch/x86/kernel/i387.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c index ac47278c..66f1053 100644 --- a/arch/x86/kernel/i387.c +++ b/arch/x86/kernel/i387.c @@ -119,9 +119,13 @@ EXPORT_SYMBOL(__kernel_fpu_end); /* * Save the FPU state (initialize it if necessary): + * + * This only ever gets called for the current task. */ void fpu__save(struct task_struct *tsk) { + WARN_ON(tsk != current); + preempt_disable(); if (__thread_has_fpu(tsk)) { if (use_eager_fpu()) { -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |