[tip:x86/build] x86/build: Remove -Wno-sign-compare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit-ID:  fd096a3bcd9718d979a7dd6253cd5b46fff66593
Gitweb:     http://git.kernel.org/tip/fd096a3bcd9718d979a7dd6253cd5b46fff66593
Author:     Ingo Molnar <mingo@xxxxxxxxxx>
AuthorDate: Mon, 11 May 2015 08:47:58 +0200
Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Mon, 11 May 2015 09:13:46 +0200

x86/build: Remove -Wno-sign-compare

Louis Langholtz noticed that we have the -Wno-sign-compare compiler option
in arch/x86/Makefile, which turns off certain, useful looking warnings.

This quirk is documented as:

   # Workaround for a gcc prelease that unfortunately was shipped in a suse release

The workaround is more than 10 years old, it was added in a large x86_64
merge in v2.5.70:

   47e4079c7da4 ("[PATCH] x86-64 merge")

(as per tglx's historic Linux Git tree.)

Probably described by line in the changelog:

   - Disable sign compare warnings for gcc 3.3-hammer

That's ancient and we generate quite a few warnings with old
GCC versions in any case. Worst case we such an ancient GCC
will generate a few more warnings.

So restore the warning and see what happens.

Reported-by: Louis Langholtz <lou_langholtz@xxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>
Cc: Brian Gerst <brgerst@xxxxxxxxx>
Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
 arch/x86/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 2fda005..ea5e259 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -160,8 +160,6 @@ LDFLAGS := -m elf_$(UTS_MACHINE)
 
 # Speed up the build
 KBUILD_CFLAGS += -pipe
-# Workaround for a gcc prelease that unfortunately was shipped in a suse release
-KBUILD_CFLAGS += -Wno-sign-compare
 #
 KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
 # prevent gcc from generating any FP code by mistake
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux