Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings
- From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 11 Feb 2013 20:47:15 -0800
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jamie Lokier <jamie@xxxxxxxxxxxxx>, ville.syrjala@xxxxxxxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, "H.J. Lu" <hjl.tools@xxxxxxxxx>
- In-reply-to: <CA+55aFx7KA-inJJog0v_cAsU0S2FeAN61pyvoUO8pbaxEAWFag@mail.gmail.com>
On Mon, Feb 11, 2013 at 8:42 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> But I don't see anything fundamentally wrong with it. Certainly it
> looks much better than the disgusting and warning-prone
>
> unsigned long long __val_gu8
>
> thing.
Oh. I just realized. That was your _baseline_ in the comparisons, wasn't it?
Can you please make the baseline be the current mainline git version
of <asm/uaccess.h>, not the first "unsigned long long __val_gu8"
version of the 64-bit get_user()?
Because we should compare against the straightforward code, not the
one that could have messed things up already..
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]