Commit-ID: 63f82f66a208efe0f5f10ed5d0cd8d32c8dfd013
Gitweb: http://git.kernel.org/tip/63f82f66a208efe0f5f10ed5d0cd8d32c8dfd013
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
AuthorDate: Tue, 22 May 2012 17:52:34 +0300
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Wed, 23 May 2012 17:11:31 +0200
sched/numa: Checking for NULL instead of IS_ERR()
If mpol_new() is called with MPOL_BIND then it can't return a
NULL pointer. We should be checking IS_ERR() here.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Link: http://lkml.kernel.org/r/20120522145233.GA17419@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
kernel/sched/numa.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/numa.c b/kernel/sched/numa.c
index de66256..25be2b1 100644
--- a/kernel/sched/numa.c
+++ b/kernel/sched/numa.c
@@ -1482,9 +1482,9 @@ SYSCALL_DEFINE4(numa_mbind, unsigned long, addr, unsigned long, len,
mask = nodemask_of_node(ng->numa_entity.node);
mpol = mpol_new(MPOL_BIND, 0, &mask);
- if (!mpol) {
+ if (IS_ERR(mpol)) {
ng_put(ng);
- return -ENOMEM;
+ return PTR_ERR(mpol);
}
mpol->flags |= MPOL_MF_LAZY;
mpol->numa_group = ng;
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|