On 21/03/2025 10:55, Svyatoslav Ryhel wrote: > Extend the Tegra124 driver to include DFLL configuration settings required > for Tegra114 compatibility. > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx> <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. </form letter> > +++ b/include/dt-bindings/reset/tegra114-car.h Filename based on compatible. > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > +/* > + * This header provides Tegra114-specific constants for binding > + * nvidia,tegra114-car. > + */ > + > +#ifndef _DT_BINDINGS_RESET_TEGRA114_CAR_H > +#define _DT_BINDINGS_RESET_TEGRA114_CAR_H > + > +#define TEGRA114_RESET(x) (5 * 32 + (x)) Does not look like a binding, but some sort of register. Binding IDs start from 0 (or 1) and are incremented by 1. Best regards, Krzysztof
