On 01/10/2024 21:35, Zichen Xie wrote:
> Thank you for your feedback!
>
> You can see from commit 90ca6956d383 ("ice: Fix freeing uninitialized
> pointers") or any other usages of __free.
> Initialization is a necessary and standard way to protect your memory.
You did not understand that commit.
>
> Additionally, the proper freeing function should be of_node_put()
> rather than device_node().
What?
> In commit 8812b8689ee6 ("firmware: tegra: bpmp: Use scoped device node
> handling to simplify error paths"),
> of_node_put() was originally set to free the memory.
What?!?!
You don't understand this code, do you?
>
> And as for the tag mistakes. We are sorry and will correct that later.
>
> Best,
Best regards,
Krzysztof
