On 01/10/2024 21:09, Gax-c wrote:
> Like commit 90ca6956d383 ("ice: Fix freeing uninitialized pointers"),
> automatically cleaned up pointers need to be initialized before exiting their scope.
So where is the early exit?
> Additionally, device_node() should be replaced with a proper freeing
> free function of_node_put() in this case.
> And the pointer need to be initialized to NULL before any return statement.
And it is already.
This looks really bogus.
>
> Fixes: 8812b8689ee6 ("firmware: tegra: bpmp: Use scoped device node handling to simplify error paths")
> Signed-off-by: Zichen Xie <zichenxie0106@xxxxxxxxx>
> Reported-by: Zichen Xie <zichenxie0106@xxxxxxxxx>
Hm? How is this possible? You are writing this patch, aren't you? This
is bogus tag.
> Reported-by: Zijie Zhao <zzjas98@xxxxxxxxx>
> Reported-by: Chenyuan Yang <chenyuan0y@xxxxxxxxx>
Where are the reports? Why three people are listed here?
This is an open source work and public collaboration. The "Reported-by"
usually means that the issue was reported to us, in some way, usually in
public. Can we see the report?
Otherwise adding non-public, non-verifiable reports is useless and
clutters our report-credit-system.
Best regards,
Krzysztof
