On Thu, Apr 18, 2024 at 04:49:04PM +0200, Niklas Cassel wrote: > On Thu, Apr 18, 2024 at 05:28:31PM +0530, Manivannan Sadhasivam wrote: > > BME which stands for 'Bus Master Enable' is not defined in the PCIe base > > spec even though it is commonly referred in many places (vendor docs). But > > to align with the spec, let's rename it to its expansion 'Bus Master > > Enable'. > > > > Suggested-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx> > > > Outside the scope of this patch/series: > Do we perhaps want to add a bus_master_enable() callback also for the > pci-epf-test driver? > Makes sense to me. > In my opinion, the test driver should be "the driver" that tests that > all the EPF features/callbacks work, at least a basic test "does it > work at all". Other EPF drivers can implement the callbacks, and do > more intelligent things, i.e. more than just seeing that "it works". > Agree. Feel free to send a patch :) - Mani -- மணிவண்ணன் சதாசிவம்
