Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()

[Thierry Reding <thierry.reding@xxxxxxxxx>]

On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote:
> debugfs_create_file() will simply return early if
>  smmu->debugfs is an error pointer.

The formatting is a little weird here.

> Make smmu->debugfs check delete in tegra_smmu_debugfs_init().

I think something like this is better:

  Delete smmu->debugfs check in ...

Or perhaps combine both sentences:

  debugfs_create_file() will return early if smmu->debugfs is an error
  pointer, so an extra error check is not needed.

With that fixed:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature