On Tue, 2023-06-06 at 14:35 +0200, Thierry Reding wrote: > On Mon, May 08, 2023 at 06:03:20PM +0800, Haotien Hsu wrote: > > From: EJ Hsu <ejh@xxxxxxxxxx> > > > > For the dual-role port, it will assign the phy dev to usb-phy dev > > and > > use the port dev driver as the dev driver of usb-phy. > > > > When we try to destroy the port dev, it will destroy its dev driver > > as well. But we did not remove the reference from usb-phy dev. This > > might cause the use-after-free issue in KASAN. > > > > Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support") > > Cc: stable@xxxxxxxxxxxxxxx > > > > Signed-off-by: EJ Hsu <ejh@xxxxxxxxxx> > > Signed-off-by: Haotien Hsu <haotienh@xxxxxxxxxx> > > --- > > V1 -> V2: Remove extra movements to clarify the change > > --- > > drivers/phy/tegra/xusb.c | 1 + > > 1 file changed, 1 insertion(+) > > Haotien, > > I had already given an Acked-by on v1. Typically you should add such > tags when you post new versions so that people don't have to repeat > them. Anyway, here it is again: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> Hi Thierry, I see. My mistake.