Hello, [dropped Tom Joseph and Joyce Ooi from Cc:, my last mail in this thread resulted in a bounce for their addresses.] On Fri, Jun 02, 2023 at 04:37:34PM -0500, Bjorn Helgaas wrote: > On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote: > > Hello Bjorn, > > > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote: > > > this series adapts the platform drivers below drivers/pci to use the > > > .remove_new() callback. Compared to the traditional .remove() callback > > > .remove_new() returns no value. This is a good thing because the driver core > > > doesn't (and cannot) cope for errors during remove. The only effect of a > > > non-zero return value in .remove() is that the driver core emits a warning. The > > > device is removed anyhow and an early return from .remove() usually yields a > > > resource leak. > > > > > > By changing the remove callback to return void driver authors cannot > > > reasonably assume any more that there is some kind of cleanup later. > > > > > > All drivers were easy to convert as they all returned zero in their > > > remove callback. Only for iproc the conversion wasn't trivial, the other > > > were converted using coccinelle. > > > > > > There are no interdependencies between these patches. So even if there > > > are some concerns for individual patches, I ask you to apply the > > > remaining set. Then I only have to care for the review feedback of the > > > refused patches. (Having said that I don't expect any serious objection, > > > just things like squashing or separating patches, or maybe I picked a > > > wrong subject prefix.) > > > > These patches wait for application for quite some time now. They apply > > just fine to v6.4-rc1 and next/master. Would be great to get them in > > during the next merge window and ideally give them some time in next > > before. > > Thanks, these seem fine to me, and Lorenzo normally takes care of > drivers/pci/controller/. Lorenzo, if it's easier to have me apply > them, that's fine, too, just let me know. > > The only tweaks I would make would be: > > PCI: j721e: Convert to platform remove callback returning void > PCI: dwc: Convert to platform remove callback returning void If it's easier for you (or Lorenzo) I can resend with these tweaks. Otherwise if these are adapted when applying them, that's fine for me, too. Just tell me if I should do anything here. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
