Re: [PATCH v5 02/18] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2023/03/02 5:14, Daniel Lezcano wrote:
The thermal zone device structure is exposed to the different drivers
and obviously they access the internals while that should be
restricted to the core thermal code.

In order to self-encapsulate the thermal core code, we need to prevent
the drivers accessing directly the thermal zone structure and provide
accessor functions to deal with.

Use the devdata accessor introduced in the previous patch.

No functional changes intended.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> #R-Car
Acked-by: Mark Brown <broonie@xxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> #MediaTek auxadc and lvts
Reviewed-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx> #Mediatek lvts
Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@xxxxxxxxxxxxxx> #da9062
Reviewed-by: Baolin Wang <>  #spread
Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> #sun8i_thermal
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> #Broadcom
Reviewed-by: Dhruva Gole <d-gole@xxxxxx> # K3 bandgap


diff --git a/drivers/thermal/uniphier_thermal.c
index 47801841b3f5..aef6119cc004 100644
--- a/drivers/thermal/uniphier_thermal.c
+++ b/drivers/thermal/uniphier_thermal.c
@@ -187,7 +187,7 @@ static void uniphier_tm_disable_sensor(struct
uniphier_tm_dev *tdev)

  static int uniphier_tm_get_temp(struct thermal_zone_device *tz, int
-	struct uniphier_tm_dev *tdev = tz->devdata;
+	struct uniphier_tm_dev *tdev = thermal_zone_device_priv(tz);

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> #uniphier

Thank you,

Best Regards
Kunihiko Hayashi

[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux