On 22/06/2022 11:08, Krzysztof Kozlowski wrote: >>> The patch was not even compiled... I consider it harmful approach. NAK. >>> See: https://lwn.net/Articles/854645/ >>> >>> Best regards, >>> Krzysztof >> >> Sorry, Krzysztof. >> >> As the patch is so simple two lines , I thought I can handle it without compiling it. >> >> Thanks very much for your notice about the article and I hope I have not done anyother harmful things. >> >> And I will take care of my patch code in future no matter how simple it is. > > > Never send patches which were not built. It seems you didn't build them > in the past either, even though setting up cross compile is trivial (few > commands). QEMU is also an easy option. > > Even though your contribution might be valuable, lack of building is a > sign for me that approach is not serious, so I am not going to take > risky code. Unless of course someone's reviews your code. :) Best regards, Krzysztof
