On 22/06/2022 06:28, Liang He wrote: > of_find_node_by_name() will decrease the refcount of its first arg and > we need to add a of_node_put() to keep refcount balance. > > Besides, during the 'for' loop execution, the refcount of 'np' will be > automatically increased and decreased. There is no need to call > of_node_put() again. > > Signed-off-by: Liang He <windhl@xxxxxxx> > --- > drivers/memory/tegra/tegra20-emc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > The patch was not even compiled... I consider it harmful approach. NAK. See: https://lwn.net/Articles/854645/ Best regards, Krzysztof
