On Sun, Dec 12, 2021 at 12:13:59AM +0300, Dmitry Osipenko wrote: > From: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx> > > If an USB port is an OTG port, then we should add the usb-role-switch > property. Otherwise XUSB setup fails and therefore padctl is unable to > set up the ports. This leads to broken USB and PCIe ports. Add the > usb-role-switch properties to Tegra124 device-trees to fix the problem. > > The error message shown without this patch is e.g: > usb2-0: usb-role-switch not found for otg mode > > [digetx@xxxxxxxxx: improved commit message] > Tested-by: Thomas Graichen <thomas.graichen@xxxxxxxxx> # T124 Nyan Big > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx> > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 + > arch/arm/boot/dts/tegra124-apalis.dtsi | 1 + > arch/arm/boot/dts/tegra124-nyan.dtsi | 1 + > arch/arm/boot/dts/tegra124-venice2.dts | 2 +- > 4 files changed, 4 insertions(+), 1 deletion(-) The device tree bindings for the XUSB pad controller say that when this property is set, then the "connector" subnode should also exist. Any chance we can add that? I was planning on making that a dependency in the json-schema conversion of the binding, in which case it would be more of a "must" than a "should". Thierry
Attachment:
signature.asc
Description: PGP signature
