On 21/08/2021 05:52, CGEL wrote: > From: jing yangyang <jing.yangyang@xxxxxxxxxx> > > Fix the following coccicheck warning: > ./drivers/memory/tegra/tegra30-emc.c:1322:0-23:WARNING: > tegra_emc_debug_max_rate_fops should be defined > with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Thanks for the patch. Same comment as with other one - where is the report? Best regards, Krzysztof > Signed-off-by: jing yangyang <jing.yangyang@xxxxxxxxxx> > --- > drivers/memory/tegra/tegra30-emc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c > index 7e21a85..80f98d7 100644 > --- a/drivers/memory/tegra/tegra30-emc.c > +++ b/drivers/memory/tegra/tegra30-emc.c > @@ -1289,7 +1289,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, > tegra_emc_debug_min_rate_get, > tegra_emc_debug_min_rate_set, "%llu\n"); > > @@ -1319,7 +1319,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, > tegra_emc_debug_max_rate_get, > tegra_emc_debug_max_rate_set, "%llu\n"); > >
