On 25/08/2021 08:37, CGEL wrote: > From: Jing Yangyang <jing.yangyang@xxxxxxxxxx> > > Fix the following coccicheck warning: > ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING > tegra210_emc_debug_min_rate_fops should be defined > with DEFINE_DEBUGFS_ATTRIBUTE > ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING > tegra210_emc_debug_temperature_fops should be defined > with DEFINE_DEBUGFS_ATTRIBUTE Thanks for the patch. One error message is enough. They are the same. > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Where is the report? We work here in a public, so if there is a report I assume we can reach it? In case the report does not exist, anyone can run checkpatch, coccinelle, smatch and sparse, so how does this differs from me running checkpatch? > Signed-off-by: Jing Yangyang <jing.yangyang@xxxxxxxxxx> > --- > drivers/memory/tegra/tegra210-emc-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c > index 06c0f17..3b8284c 100644 > --- a/drivers/memory/tegra/tegra210-emc-core.c > +++ b/drivers/memory/tegra/tegra210-emc-core.c > @@ -1692,7 +1692,7 @@ static int tegra210_emc_debug_max_rate_set(void *data, u64 rate) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_max_rate_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_max_rate_fops, > tegra210_emc_debug_max_rate_get, > tegra210_emc_debug_max_rate_set, "%llu\n"); > > @@ -1723,7 +1723,7 @@ static int tegra210_emc_debug_temperature_set(void *data, u64 temperature) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_temperature_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_temperature_fops, > tegra210_emc_debug_temperature_get, > tegra210_emc_debug_temperature_set, "%llu\n"); > > Best regards, Krzysztof
