On Mon, Jun 21, 2021 at 04:11:55PM +0200, Thierry Reding wrote: > On Mon, Jun 21, 2021 at 08:46:54AM +0200, Krzysztof Kozlowski wrote: > > On 18/06/2021 21:47, Rob Herring wrote: > > > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > >> index 9d27aa5111d4..1181b590db71 100644 > > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > >> @@ -54,8 +54,14 @@ properties: > > >> - const: arm,mmu-500 > > >> - description: NVIDIA SoCs that program two ARM MMU-500s identically > > >> items: > > >> + - description: NVIDIA SoCs that require memory controller interaction > > > > > > This is not valid jsonschema: > > > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > > > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > > > must be fixed: > > > None is not of type 'object', 'boolean' > > > None is not of type 'array' > > > from schema $id: http://json-schema.org/draft-07/schema# > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > > must be fixed: > > > None is not of type 'object' > > > None is not of type 'array' > > > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > > must be fixed: > > > None is not of type 'object' > > > None is not of type 'array' > > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > > > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > > > must be fixed: > > > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > > > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > > > type 'object' > > > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > > > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > > > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > > > > > > > This was not reviewed nor tested since the DT list was not Cc'ed. > > > > Ugh, I see now weird empty item on a list... and not only DT list was > > skipped - Thierry did not Cc you either. > > This seemed like a too trivial addition to waste Rob's time on, so I > didn't add him (or the DT list for that matter) on Cc. The ARM SMMU > maintainers had reviewed this, which seemed like it was enough for what > the DT bindings change was doing. Hmm, I didn't review it. I find the yaml stuff unreadable so I usually wait for the DT folks to ack bindings changes before I queue them in the SMMU tree. Will
