On 18/06/2021 21:47, Rob Herring wrote: > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: >> >> From: Thierry Reding <treding@xxxxxxxxxx> >> >> The ARM SMMU instantiations found on Tegra186 and later need inter- >> operation with the memory controller in order to correctly program >> stream ID overrides. >> >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up >> to achieve higher throughput. In order to do this, they have to be >> programmed identically so that the memory controller can interleave >> memory accesses between them. >> >> Add the Tegra186 compatible string to make sure the interoperation >> with the memory controller can be enabled on that SoC generation. >> >> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 9d27aa5111d4..1181b590db71 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -54,8 +54,14 @@ properties: >> - const: arm,mmu-500 >> - description: NVIDIA SoCs that program two ARM MMU-500s identically >> items: >> + - description: NVIDIA SoCs that require memory controller interaction > > This is not valid jsonschema: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > must be fixed: > None is not of type 'object', 'boolean' > None is not of type 'array' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > must be fixed: > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > type 'object' > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > This was not reviewed nor tested since the DT list was not Cc'ed. Ugh, I see now weird empty item on a list... and not only DT list was skipped - Thierry did not Cc you either. My bad, I did not check that patch thoroughly before applying. Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a fix or a revert, if fix needs more time. Additionally, why the patch changes reg to "minItems: 1" for nvidia,tegra194-smmu? Best regards, Krzysztof
