On Tue, Jun 15, 2021 at 07:21:35PM +0100, Will Deacon wrote: > On Tue, Jun 15, 2021 at 06:12:13PM +0000, Krishna Reddy wrote: > > > if (smmu->impl->probe_finalize) > > > > The above is the issue. It should be updated as below similar to other instances impl callbacks. > > if (smmu->impl && smmu->impl->probe_finalize) > > I'll push a patch on top shortly... Done: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-thierry/arm-smmu I'll send this lot to Joerg tomorrow. Thierry -- feel free to pull in the updated branch if you want the fix sooner, as it may be a few days before this hits -next. Cheers, Will